Giters

Skyost / RateMyApp

This plugin allows to kindly ask users to rate your app if custom conditions are met (eg. install time, number of launches, etc...).

Home Page:https://pub.dev/packages/rate_my_app

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

StarRatinngOptions glowColor is being ignored

kristijorgji opened this issue · comments

commented 
starRatingOptions: StarRatingOptions(
      initialRating: 0.0,
      glowColor: Colors.green,
    ),

Still the stars are shown in orange

I migrated code from rate_my_app: ^0.6.1+3 to rate_my_app: ^1.1.0+1

Previously this worked fine with old format of styles which I found better

starRatingOptions: StarRatingOptions(
        initialRating: null,
        starsBorderColor: Colors.green,
        starsFillColor: Colors.green),

with new version I converted to

    starRatingOptions: StarRatingOptions(
      initialRating: 0.0,
      glowColor: Colors.green,
    ),

but as mentioned color does not work. Would be great to again have possiblilty change border and star fill color like in previous version, was very clear customisable and worked great

commented

Glow color does not modify widget color. It only changes the 'glow' when you interact with the rating bar.

I added a PR to fix this issue and give the ability to use custom widgets. Hopefully, it will get merged. Or maybe somebody will come up with a better solution.

commented

Hi, thanks I would suggest you just revert it as it was back in old version ^0.6.1+3, worked fantastic allowing to customise both colors like:

starRatingOptions: StarRatingOptions(
        initialRating: null,
        starsBorderColor: Colors.green,
        starsFillColor: Colors.green),

Of course your pr is very useful also for specifying custom widget for people that want to do so, but in most cases i am sure we just want to use default widget and change colors like above matching app style

commented

Well, I added only the item color change. I'm not a writer of this repo, so I don't know why they changed it, but I think that it is because of the underlying dependency, 'flutter_rating_bar' changed. It no longer has those fill-color and border-color properties. So I don't know whether it is possible to revert those changes. But I'll try to come up with some workaround to give support for both color changes.

commented

This PR #104 now adds support for border color customization as well