Configuration::addPathsSection() not compatible with propel 2.0.0-beta2
benstinton opened this issue · comments
Thanks for forking this bundle and keeping it current.
I'm using it to migrate a large legacy project from SF3 to SF4 then onwards. I am having to use v5.0.1 but I am having an issue:
`Fatal error: Declaration of Propel\Bundle\PropelBundle\DependencyInjection\Configuration::addPathsSection(Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition $node) must be compatible with Propel\Common\Config\Propel
Configuration::addPathsSection(Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition $node): void in /var/www/vendor/skyfox/propel-bundle/DependencyInjection/Configuration.php on line 32
addPathsSection
addRuntimeSection
addDatabaseSection
all need a return type of 'void' according to propel/propel 2.0.0-beta2
`
It look's like it should be a simple fix, is this something you can help with or would you like me to submit a PR? I don't have much time on this topic, so it would be great to hear back one way or another
Hello,
sorry for the delay.
the mistake is mine i did mess up README file for branch 5.1 which was telling you to use 5.0 not 5.1 branch.
Please change composer.json to include "skyfox/propel-bundle": "^5.1" (or tag/release 5.1.0) not "skyfox/propel-bundle": "^5.0.1", this change should download branch 5.1 which uses return type void on all function above.
Please tell me if fix the problem so i can close the issue.