SimronThapa / FSRN-CVPR2020

This codebase implements the system described in the paper: Dynamic Fluid Surface Reconstruction Using Deep Neural Network

Home Page:https://ivlab.cse.lsu.edu/FSRN_CVPR20.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Found bug in "Fluid_wave_simulator"

OriLifschitz opened this issue · comments

Hello

Impressive work, thank you for publishing code @SimronThapa

I believe I might have found a bug in the fluid_simulator:

WaveLimit = patchSize/100;

While the WaveLimit, as defined in the paper "Simulating Ocean Water" by Jerry Tessendorf is:

image

This explains why visually pleasing results with the bug require using 200[m/s] wind speed.

So the correct code would be:

WaveLimit = L/100
Use L instead of Lx or Lz (Lx=Lz=PatchSize in the simulator code)

Best regards,
Ori.