Shopify / quilt

A loosely related set of packages for JavaScript/TypeScript projects at Shopify

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Phone Formatter package

eylamf opened this issue · comments

Overview

Similar to the @shopify/address package, we want to extract the PhoneNumberFormatter utility from @shopify/web's utilities folder, into its own Quilt package so that it can be used in different codebases within Shopify in order to ensure alignment on how we format phone numbers across Shopify.

Type

  • New feature
  • Changes to existing features

Motivation

What inspired this feature request? What problems were you facing,
or what else makes you think this should be in quilt?

We have multiple apps within Shopify that need this functionality (web Admin and Inbox), and we want to be consistent with all the usages.

Area

  • Add any relevant Area: <area> labels to this issue

Scope

  • Is this issue related to a specific package?

    • Tag it with the Package: <package_name> label.
  • Is it related to a new package?

    • Tag it with the New package Label

Checklist

  • Please delete the labels section before submitting your issue
  • I have described this issue in a way that is actionable (if possible)

We have multiple apps within Shopify that need this functionality, and we want to be consistent with all the usages.

Mind adding which apps would be dependent on this library?

Mind adding which apps would be dependent on this library?

Just updated to include web Admin and Inbox in the description ✔️

What repo is Inbox in?

Inbox client is a react native and react native web application hosted here https://github.com/Shopify/inbox-client

We are happy to be the owners/maintainers of this package as the Inbox team is part of the Relationships team that is responsible for the customer profile in admin, which commonly displays phone numbers

Sounds good. Thanks for clarifying