Shopify / liquid

This is obscure and we do support it but behaves rather strangely. We should deprecate this.

{% assign product.img = "hi" %}

{% # prints nothing %}
{{ product.img }}

{% # prints "hi" %}
{{ ["product.img"] }}

It's because we parse the entire assign LHS as a string and then assign the context's <stringValueOfLHS> to be the value of the RHS. And our VariableSegment regex accepts dots and square brackets.

liquid/lib/liquid/tags/assign.rb

Line 38 in 81f44e3

context.scopes.last[@to] = val

liquid/lib/liquid/tags/assign.rb

Line 17 in 81f44e3

Syntax = /(#{VariableSignature}+)\s*=\s*(.*)\s*/om

liquid/lib/liquid.rb

Line 33 in 81f44e3

VariableSignature = /\(?[\w\-\.\[\]]\)?/

While we're there, we should probably cleanup our regex for variable segment, variable signature, etc.

Deprecate variableLookups on LHS of assign.