Shopify / hydrogen-v1

React-based framework for building dynamic, Shopify-powered custom storefronts.

Home Page:https://shopify.github.io/hydrogen-v1/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[BUG] eslint-plugin-jest installed unecessarily

tim-millar opened this issue · comments

Describe the bug

We are using the hydrogen eslint plugin to lint our hydrogen project. We are also using vitest for unit testing (per the recommendations in the docs). When I run eslint in the project, it errors because it can't determine the jest version we're running - even though jest isn't installed or configured.

Screenshot 2023-01-12 at 17 24 15

After digging a bit, it seems as though eslint-plugin-hydrogen installs eslint-plugin-jest as a dependency. Since the intention seems to be for hydrogen projects to prefer vitest over jest, I'm guessing that this the result of some kind of oversight. Perhaps it should have been installed as a development dependency instead?

Screenshot 2023-01-12 at 17 34 43

Thanks