Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Endless loading issue with filter in main-collection-product-grid.liquid

tanwanjern opened this issue · comments

Describe the current behavior

889e2a0#r140901401

In the main-collection-product-grid.liquid file, the data-id attribute was recently moved from the ul to its parent div. Can I know why?

This change led to unexpected behavior where filtering caused endless loading until the attribute was reverted back to ul.

The error message received is:
Cannot read properties of null (reading 'innerHTML') at FacetFiltersForm.renderProductGridContainer

Describe the expected behavior

Smooth filtering without endless loading. Additionally, the error message should be resolved.

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 13.0.1
  • Chrome Version 123.0.6312.59
  • macOS Version 13.5

Possible solution

Move data-id="{{ section.id }}" back to <ul id="product-grid">

Additional context/screenshots

image

#3421 Resolved in version 14.0.0.