ShokoAnime / ShokoServer

Repository for Shoko Server.

Home Page:http://shokoanime.com/shoko-server/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Groups created with "Short" name instead of "Main"

krbrs opened this issue · comments

commented

VERSION INFORMATION

Server Version: latest daily

Desktop Version: latest daily

DESCRIPTION

After adding a series I found a weird group name like this (I could not say from the start which series it is):

groupname_1 groupname_2

I found this to be the short name of the series instead of the "main" name. It's these two series for me which did cause this:

https://anidb.net/perl-bin/animedb.pl?show=anime&aid=13171
https://anidb.net/perl-bin/animedb.pl?show=anime&aid=14572
https://anidb.net/perl-bin/animedb.pl?show=anime&aid=12560

STEPS TO REPRODUCE

Just add these series to Shoko, the groups need to be not present before.

commented

Found use that while talking to @revam, that "use synonyms" makes it do that.

Also my prefs are missing "x-zht", which is why that happens in the first place.

I will tinker around what language is "x-zht" in the language options as it's not present as "Pinyin" on Shoko webui + desktop and note it down here later (+ might make a pr for changing it when I have time again)

I would like it to default to "main" instead of "short" tho, if none of the preferred options are available, then resort to the synonym which seems to be the "short" name. Will removing "use synonyms" do that?

Removing "use synonyms" will make it default to the main title if no main or official title in any of the preferred languages are set for a series, yes. "Use synonyms" makes it so it does an additional check for any title in the preferred languages and uses that if any are found.

commented

I will close this issue now as the commits should provide the desired behavior in the future.
Also after disabling the synonyms series were renamed as expected.

For ShokoDesktop a manual daily build needs to be triggered after the Commons changed - it's not automatically done (at least it seems like this from the actions).