ShiftMediaProject / FFVS-Project-Generator

A program that can scan existing FFmpeg/LibAV source files and dynamically generate a Visual Studio project file.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Some path resolution exceptions

836454543 opened this issue · comments

commented

The function ConfigGenerator::makeFileGeneratorRelative return "" when the relative path is ./.
And the code in ProjectGenerator::runMSVC

string projectDir = m_configHelper.m_solutionDirectory;
m_configHelper.makeFileGeneratorRelative(projectDir, projectDir);  // projectDir == ""
...
for (auto& i : includeDirs2) {
    ...
    // i == "$(ProjectDir)/../compat/atomics/win32/"
    findPos2 = i.find("$(ProjectDir)");
            if (findPos2 != string::npos) {
                // i == "/../compat/atomics/win32/", ERROR!!!
                // It should be "./../compat/atomics/win32/" or "../compat/atomics/win32/"
                i.replace(findPos2, 13, projectDir);
            }
   ...
}

I am sorry for my pool English.