Serubin / pulse-sms-web

The official web app for Pulse SMS - built on Vue.js.

Home Page:https://pulsesms.app

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add async loading

ssebs opened this issue · comments

It would be nice if the extension (or page) loaded a loading bar or something, then loads the data.

Currently, when I click on the extension to view my messages, it freezes chrome for a second.

Example:

gif

Thanks!

I don't think a loading bar would do anything here. Clicking the item just opens this

https://github.com/klinker-apps/messenger-chrome/blob/master/browser-extension/popup.html

All that page is, is an iframe showing the website. It displays the popup before the website is loaded, so I don't think that loading the UI is where it is freezing.

If you have suggestions, feel free to make a PR for this.

The website itself does the same thing though, it takes a second or two to load. During that time it just hangs while loading.

I'll have to find some time and see if I can submit a PR.

This isn't an issue with the web app. I did some review, the web app transfers approximately 100kb uncached. On a 1mbit connection, the web app will have first render at 1.1 seconds with no caching and .2 seconds with caching.

It's possible the web app is loading slow for you, for whatever reason (though we have improved loading speed in the last 6 months), but ultimately this needs to be fixed in the chrome extension code.