Serhioromano / vscode-st

VAR and END_VAR incorrectly scope when run in to other identifiers in certain orders

VAR does not validate word break at end, END_VAR does not validate work break at either end.

VAR_x seem to be same as VAR

Looks like the \b is missing from the end of both the begin and end clauses.

If you put all in one line not sure it is fixable. Scope is defined with JSON file, and basically as I understand it, VS Code takes care of scopes, open\close brackets.

vscode-st/syntaxes/st.tmLanguage.json

Lines 220 to 226 in f33afa2

    
           "begin": "\\b(?:VAR(?:_(?:INPUT|OUTPUT|IN_OUT|TEMP|GLOBAL|ACCESS|EXTERNAL))?|STRUCT|UNION|PUBLIC|PRIVATE|PROTECTED)", 
        
           "beginCaptures": { 
        
           	"0": { 
        
           		"name": "entity.name.type.st" 
        
           	} 
        
           }, 
        
           "end": "(?:END_(?:VAR|STRUCT|UNION))",

"begin": "\\b(?:VAR(?:_(?:INPUT|OUTPUT|IN_OUT|TEMP|GLOBAL|ACCESS|EXTERNAL))?|STRUCT|UNION|PUBLIC|PRIVATE|PROTECTED)\\b",

"end": "\\b(?:END_(?:VAR|STRUCT|UNION))\\b",

(different coloring here, but now the keywords run together are no longer 'keywords')

(different coloring here, but now the keywords run together are no longer 'keywords')

Is that how it supposed to behave? Looks correct to me. You can PR this change.

After Appling correction:

	"begin": "\\b(?:VAR(?:_(?:INPUT\|OUTPUT\|IN_OUT\|TEMP\|GLOBAL\|ACCESS\|EXTERNAL))?\|STRUCT\|UNION\|PUBLIC\|PRIVATE\|PROTECTED)",
	"beginCaptures": {
	"0": {
	"name": "entity.name.type.st"
	}
	},
	"end": "(?:END_(?:VAR\|STRUCT\|UNION))",

VAR/END_VAR scope when as parts of other identifiers