Giters

SerenityOS / ladybird

The Ladybird web browser

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

sys/cdefs.h is non-standard

ddevault opened this issue · comments

commented 
/usr/include/sys/cdefs.h:1:2: error: #warning usage of non-standard #include <sys/cdefs.h> is deprecated [-Werror=cpp]
    1 | #warning usage of non-standard #include <sys/cdefs.h> is deprecated
      |  ^~~~~~~
commented

Which header did this come from? Was it LibThreading/ConditionVariable.h or somewhere else?

If it was, a cleanup PR to https://github.com/SerenityOS/serenity to remove that header and sys/types.h would be much appreciated. That header should only be included from libraries that are serenity-only.

commented

Appears to have come from regex-related stuff. Did not look into it too deeply, feel free to close if this isn't useful.

commented

Ah hm. LibRegex seems to include LibC/regex.h. that's ... not ideal. This is really an issue with Serenity though, rather than ladybird.