Giters

Sententiaregum / Sententiaregum

A social network based on Symfony3 and ReactJS.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

consider removing PHPCS

Ma27 opened this issue · comments

commented

Description

According to the support of StyleCI they aren't fully compliant with the rules of PHPCS. There were issues like #309 that caused a pain to fix. Furthermore there are more plans of PHPCS to build custom rules that could cause more pain in the future.

Thefore the following suggestion:

  • Our CS is quite well now due to many linters, so a StyleCI which simply tells people in PRs to keep their style clean is enough
  • If some broken code exists due to changing rules for instance, StyleCI might generate a PR
commented

@benbieler WDYT about that?

commented

@Ma27 Yeah, sounds like a plan...