Store Keybinds in DB as Unicode instead of plaintext
broxen opened this issue · comments
Summary
Current keybinds are stored in the database as plaintext inside of a json blob. This winds up with potentially dangerous text combinations such as:
{
"Key": 39,
"Mods": 0,
"KeyString": ";",
"Command": "show chat$$slashchat",
"IsSecondary": true
},
{
"Key": 40,
"Mods": 0,
"KeyString": "'",
"Command": "quickchat",
"IsSecondary": false
},
As ;
and '
are special characters in SQL queries, it would be best to store ;
and '
, or any KeyString, as unicode (UTF-8?) point values to prevent any potential issues \u003B