Tautologous Repy API definitions in repy.py
choksi81 opened this issue · comments
At the time of writing (r6962), repy.py
(code here) calls namespace.wrap_and_insert_api_functions
(code here) with a nearly empty user context in order to let namespace
set up the Repy API the user will use. repy.py
however overwrites two definitions, getresources
and createvirtualnamespace
, and also adds a completely new one, getlasterror
.
In the comments in repy.py
, we have two places labelled "BAD" that seem to talk about removing those overwrites/adds as well as an import. In RepyV1, we only call namespace
and don't overwrite/add things. My feeling is that we should remove the "BAD" stuff, and add getlasterror
to namespace
, but I'd like to have a second opinion on that.