Broken build with PHP 5.x
remicollet opened this issue · comments
Despite package.xml states 5.4.0 as minimal supported version
Perhaps simpler to fix the package.xml instead of trying to fix build for old unsupported PHP 5.x
For memory
/builddir/build/BUILD/php-pecl-seasclick-0.1.1/NTS/SeasClick.cpp: In function 'void zim_SEASCLICK_RES_NAME___construct(int, zval*, zval**, zval*, int)':
/builddir/build/BUILD/php-pecl-seasclick-0.1.1/NTS/SeasClick.cpp:249:105: error: 'sc_zend_update_property_long' was not declared in this scope
sc_zend_update_property_long(SeasClick_ce, this_obj, "port", sizeof("port") - 1, Z_LVAL_P(value));
^
/builddir/build/BUILD/php-pecl-seasclick-0.1.1/NTS/SeasClick.cpp:255:119: error: 'sc_zend_update_property_long' was not declared in this scope
sc_zend_update_property_long(SeasClick_ce, this_obj, "compression", sizeof("compression") - 1, Z_LVAL_P(value));
^
Please, also provide a useful changelog in this package.xml , instead of no meaning "Second version for pecl.net "
Please, also provide a useful changelog in this package.xml , instead of no meaning "
Second version for pecl.net"
Ok, i wiil get a useful changelog in next version package.xml
fixed