Support for pipewire VideoTransform information
IlyaMZP opened this issue · comments
Feature summary
I use xdg-desktop-portal-wlr on sway and currently if I record my flipped monitor with Kooha, the video is flipped too. This is expected, as the portal implementation doesn't transform its buffers. But it would be great if Kooha could receive the VideoTransform meta information from pipewire and apply videoflip filter to it.
How would you like it to work
AFAIK Kooha uses pipewiresrc from gstreamer, which sends an event with an image-orientation tag. It should be possible to use videoflip element and change its method property (or maybe save rotation in video metadata) if we receive the image orientation event. But I'm not sure how it would affect other elements in the pipeline.
Relevant links, screenshots, screencasts, etc.
This feature has been added to OBS: obsproject/obs-studio#7762
This feature request is related to #250
An example python script that listens for the event: https://gist.github.com/IlyaMZP/fe75ca1df4cbe058fbcff489c8514e4c
Thanks for reporting! I'll check about it.
I'm not sure if this should be implemented upstream on pipewiresrc, but we'll see.
I'm not sure if this should be implemented upstream on
pipewiresrc, but we'll see.
It is implemented, here is the relevant code in pipewiresrc: https://github.com/PipeWire/pipewire/blob/e5c810c0fa3d0e0691a17ed65c786dd4f6bfa893/src/gst/gstpipewiresrc.c#L615
I see, thanks. Kooha's side, it is.
Hi, I have pushed a fix in the main branch. If you have the time, please test it. Thanksss!
Hi, I have pushed a fix in the main branch. If you have the time, please test it. Thanksss!
Awesome, it works! Didn't know videoflip could process video orientation automatically, that's nice to know. Thanks!
Thanks for confirming!