Schneegans / Fly-Pie

:pie: Fly-Pie is an innovative marking menu written as a GNOME Shell extension.

Home Page:http://schneegans.github.io/news/2021/12/02/flypie10

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

No icon preview in menu editor for icons from ~/.local/share/icons

TomSaw opened this issue · comments

In Linux, icons stored in /home/my_user/.local/share/icons can be used by just typing the icons filename without the path nor mime-type extension.

I've got a /home/my_user/.local/share/icons/sewing_machine.svg f.e.

In flypies menu-editor no icon is shown:
Screenshot from 2022-09-22 09-34-24

However, when using the menu the icon appears
Screenshot from 2022-09-22 09-34-59

System

  • Fedora Workstation 36
  • Fly-Pie 17
  • GNOME 42.4

Thanks for the report! I'll look into this, I hope that this is pretty easy to fix 😄

Yep, it feels like there's a working and a broken variant of "the code loading the icon". Should be fixed easily

Ugh, it's a more complex thing. The issue is that the settings dialog uses GTK4 and the actual menu uses GTK3 for discovering icons. Both seem to behave differently here. While GTK3 also returns icons which are in the top-level directory of a icon search path (e.g. .local/share/icons), GTK4 seems to follow the freedesktop specification more strictly and only searches for icons in icon-theme sub-directories only.

This means, everything should work if you put your icon into this directory instead: .local/share/icons/hicolor/scalable/actions. Simply create it if it does not exist. With this, you extend the standard hicolor icon theme and both, GTK3 and GTK4 seem to be happy 😉

Does this work for you?

Wohaa... Works
Not an issue.
Thanks a lot!