ScaleLeap / selling-partner-api-sdk

A fully typed TypeScript and Node.js SDK library for Amazon Selling Partner API

Home Page:https://npm.im/@scaleleap/selling-partner-api-sdk

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

getPackingSlip and getPackingSlips, getShippingLabel and more are missing

optikalefx opened this issue ยท comments

From the docs I was emailed these should exist on VendorDirectFulfillmentShippingApiClient

image

Missing methods

  • Submit Shipping Labels Request
  • Get Shipping Labels
  • Get Shipping Label
  • Submit Shipment Confirmations Request
  • Get Packing Slips
  • Get Packing Slip
commented

These are probably old docs. We codegen the client from official OpenAPI specs. We cannot manually add endpoints.

I suggest you raise this issue in the official repo of sp API.

I actually see that these generated 11 hours ago. So I think this is still an issue.

This is someone else's generated docs from the swagger from the github comments.

image

https://spapi.mijing.io/

commented

@nguyentoanit please check to make sure we have all models covered.

@optikalefx Thank you for the reported issue. We'll look into it.

Thanks! I believe this is the offending line, just not exporting them all.

} from '../api-models/vendor-direct-fulfillment-shipping-api-model'

import {
  Configuration,
  CustomerInvoicesApi,
} from '../api-models/vendor-direct-fulfillment-shipping-api-model'

Looks like swagger generates three classes for vendor-direct-fulfillment-shipping-api

  • CustomerInvoicesApi
  • VendorShippingApi
  • VendorShippingLabelsApi

Seems like the scale leap generator template is looking for a one-to-one mapping. This is causing the first-class CustomerInvoicesApi to be used as the base class excluding the other two.

Any change to modify the generator template to accept more than one class per model?

commented

Thank you @josh-fisher for your assessment. We'll fix this soon. It's definitely an oversight. Cheers!

๐ŸŽ‰ This issue has been resolved in version 4.1.2 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€