SavchenkoValeriy / emacs-chocolate-theme

🍫A dark chocolatey theme for Emacs 🍫

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Marking and highlighting things is problematic if hl-line mode is used globally

localredhead opened this issue · comments

image

In the screen shot I'm highlighting that row of json with market-set (as if I'm going to yank or paste). I also have hl-line mode on. With hl-line themed the same as the region I have to customize the theme to make one or the other distinct.

Digging into the configs, Transitional Mark mode uses whatever is themed in the Region face.
image

Region:
image

This is also the same face that is used for hl-line face is set to:
image

Also thank you for all the great work on this theme. I like this color palette a lot. 🏅

@localredhead Thank you very much for your kind words! I really appreciate it 😳

As for the topic, I see the problem. What about the following solution (I introduced a new color in between background and region):
Screenshot 2019-07-31 at 10 32 39
hl-line on its own looks like this then:
Screenshot 2019-07-31 at 10 37 06

This solution, though, might be too subtle, so here's a bit brighter option:
Screenshot 2019-07-31 at 10 43 56
Screenshot 2019-07-31 at 10 42 40

What do you think?

I think the brighter option looks quite good!

Great to hear!