Saurabh3333 / give-me-a-joke

A npm-module for random and customized jokes.

Home Page:https://www.npmjs.com/package/give-me-a-joke

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Change Requests To Axios

ephraimduncan opened this issue · comments

Requests is deprecated and as it is working now, It may not in the near future.
I think changing the major underlining requests library from request to axios is better.

Would you like to contribute to it?

Sure, Axios uses promises and that makes it a bit complicated. I have cloned it and I am trying it out. I will get to you for review after.

I have opened the request. I am waiting for your review

Merged.
Thank you for your contribution.
Let me know if you want to enhance this module in any way.