ScanRule Naming Consistency
kingthorin opened this issue · comments
Rick M commented
Related to: zaproxy/zaproxy#6049
https://github.com/SasanLabs/owasp-zap-jwt-addon/blob/master/src/main/java/org/zaproxy/zap/extension/jwt/JWTActiveScanner.java should be renamed JWTActiveScanRule
or JwtActiveScanRule
Of course you don't have to conform to that since this is project is 3rd party, so close/address as you see fit. But it's a pretty simple change and helps bring consistency and clarity/specificity.
Karan Preet Singh Sasan commented
@kingthorin Sure will take care of this.
Keenal Shah commented
I will like to work on this, please let me know if I can!
Karan Preet Singh Sasan commented
Hi @Keenal ,
Assigned it to you.
Thanks,
Karan
Keenal Shah commented
Done! #13