Adding unit testing framework and unit tests to VulnerableApp Facade

Question

Adding unit testing framework and unit tests to VulnerableApp Facade

preetkaran20 opened this issue 2 years ago · comments

Karan Preet Singh Sasan commented 2 years ago

Justin Hong · Answer 1 · Sat Mar 19 2022 14:07:54 GMT+0800 (China Standard Time)

@preetkaran20 I'd like to help with this effort by setting up jest and react-testing-library for the React application.

Karan Preet Singh Sasan · Answer 2 · Sat Mar 19 2022 16:00:04 GMT+0800 (China Standard Time)

Sure assigned.

Justin Hong · Answer 3 · Sun Mar 20 2022 07:21:00 GMT+0800 (China Standard Time)

@preetkaran20 First PR towards this effort :)

Justin Hong · Answer 4 · Fri May 27 2022 13:11:48 GMT+0800 (China Standard Time)

took a break but am back. Wrote some unit tests for the LeftNav
#69

Justin Hong · Answer 5 · Thu Jun 09 2022 11:04:24 GMT+0800 (China Standard Time)

added unit tests for the HomePage.tsx #70

Justin Hong · Answer 6 · Tue Jul 12 2022 15:00:24 GMT+0800 (China Standard Time)

added unit tests for the VulnerableApp CommandInjection main content #72

Karan Preet Singh Sasan · Answer 7 · Wed Jul 13 2022 02:06:29 GMT+0800 (China Standard Time)

@Dripcoding I am seeing some errors while running npm test in my PR: https://github.com/SasanLabs/VulnerableApp-facade/runs/7307184077?check_suite_focus=true
It seems like it is trying to connect to the docker container. Do we need docker container to be running?

Justin Hong · Answer 8 · Thu Jul 21 2022 11:56:47 GMT+0800 (China Standard Time)

@preetkaran20 Thanks for bringing this up! I assume you mean these warnings:

console.error Error: Error: connect ECONNREFUSED 127.0.0.1:80 at Object.dispatchError (/home/runner/work/VulnerableApp-facade/VulnerableApp-facade/facade-app/node_modules/jsdom/lib/jsdom/living/xhr/xhr-utils.js:63:19) at Request.<anonymous> (/home/runner/work/VulnerableApp-facade/VulnerableApp-facade/facade-app/node_modules/jsdom/lib/jsdom/living/xhr/XMLHttpRequest-impl.js:655:18) at Request.emit (events.js:412:35) at ClientRequest.<anonymous> (/home/runner/work/VulnerableApp-facade/VulnerableApp-facade/facade-app/node_modules/jsdom/lib/jsdom/living/helpers/http-request.js:121:14) at ClientRequest.emit (events.js:400:28) at Socket.socketErrorListener (_http_client.js:475:9) at Socket.emit (events.js:400:28) at emitErrorNT (internal/streams/destroy.js:106:8) at emitErrorCloseNT (internal/streams/destroy.js:74:3) at processTicksAndRejections (internal/process/task_queues.js:82:21) undefined at VirtualConsole.<anonymous> (node_modules/jsdom/lib/jsdom/virtual-console.js:29:45) at Object.dispatchError (node_modules/jsdom/lib/jsdom/living/xhr/xhr-utils.js:66:53) at Request.<anonymous> (node_modules/jsdom/lib/jsdom/living/xhr/XMLHttpRequest-impl.js:655:18) at ClientRequest.<anonymous> (node_modules/jsdom/lib/jsdom/living/helpers/http-request.js:121:14)

It looks like the tests are attempting to fetch the content from the BE service which is not ideal. I'll work on a fix for this.

Justin Hong · Answer 9 · Thu Jul 21 2022 13:04:54 GMT+0800 (China Standard Time)

@preetkaran20 Ok I think this should fix the errors

#74

Karan Preet Singh Sasan · Answer 10 · Thu Jul 21 2022 13:26:38 GMT+0800 (China Standard Time)

@Dripcoding thanks for looking into the issue.

Karan Preet Singh Sasan · Answer 11 · Thu Jul 21 2022 13:38:13 GMT+0800 (China Standard Time)

@Dripcoding I am still facing this issue:


    console.error
      Error: Error: connect ECONNREFUSED 127.0.0.1:80
          at Object.dispatchError (/home/runner/work/VulnerableApp-facade/VulnerableApp-facade/facade-app/node_modules/jsdom/lib/jsdom/living/xhr/xhr-utils.js:63:19)
          at Request.<anonymous> (/home/runner/work/VulnerableApp-facade/VulnerableApp-facade/facade-app/node_modules/jsdom/lib/jsdom/living/xhr/XMLHttpRequest-impl.js:655:18)
          at Request.emit (events.js:412:35)
          at ClientRequest.<anonymous> (/home/runner/work/VulnerableApp-facade/VulnerableApp-facade/facade-app/node_modules/jsdom/lib/jsdom/living/helpers/http-request.js:121:14)
          at ClientRequest.emit (events.js:400:28)
          at Socket.socketErrorListener (_http_client.js:475:9)
          at Socket.emit (events.js:400:28)
          at emitErrorNT (internal/streams/destroy.js:106:8)
          at emitErrorCloseNT (internal/streams/destroy.js:74:3)
          at processTicksAndRejections (internal/process/task_queues.js:82:21) undefined
      at VirtualConsole.<anonymous> (node_modules/jsdom/lib/jsdom/virtual-console.js:29:45)
      at Object.dispatchError (node_modules/jsdom/lib/jsdom/living/xhr/xhr-utils.js:66:53)
      at Request.<anonymous> (node_modules/jsdom/lib/jsdom/living/xhr/XMLHttpRequest-impl.js:655:18)
      at ClientRequest.<anonymous> (node_modules/jsdom/lib/jsdom/living/helpers/http-request.js:121:14)
    console.error
      Error: Error: connect ECONNREFUSED 127.0.0.1:80
          at Object.dispatchError (/home/runner/work/VulnerableApp-facade/VulnerableApp-facade/facade-app/node_modules/jsdom/lib/jsdom/living/xhr/xhr-utils.js:63:19)
          at Request.<anonymous> (/home/runner/work/VulnerableApp-facade/VulnerableApp-facade/facade-app/node_modules/jsdom/lib/jsdom/living/xhr/XMLHttpRequest-impl.js:655:18)
          at Request.emit (events.js:412:35)
          at ClientRequest.<anonymous> (/home/runner/work/VulnerableApp-facade/VulnerableApp-facade/facade-app/node_modules/jsdom/lib/jsdom/living/helpers/http-request.js:121:14)
          at ClientRequest.emit (events.js:400:28)
          at Socket.socketErrorListener (_http_client.js:475:9)
          at Socket.emit (events.js:400:28)
          at emitErrorNT (internal/streams/destroy.js:106:8)
          at emitErrorCloseNT (internal/streams/destroy.js:74:3)
          at processTicksAndRejections (internal/process/task_queues.js:82:21) undefined
      at VirtualConsole.<anonymous> (node_modules/jsdom/lib/jsdom/virtual-console.js:29:45)
      at Object.dispatchError (node_modules/jsdom/lib/jsdom/living/xhr/xhr-utils.js:66:53)
      at Request.<anonymous> (node_modules/jsdom/lib/jsdom/living/xhr/XMLHttpRequest-impl.js:655:18)
      at ClientRequest.<anonymous> (node_modules/jsdom/lib/jsdom/living/helpers/http-request.js:121:14)
    console.error
      Error: Error: connect ECONNREFUSED 127.0.0.1:80
          at Object.dispatchError (/home/runner/work/VulnerableApp-facade/VulnerableApp-facade/facade-app/node_modules/jsdom/lib/jsdom/living/xhr/xhr-utils.js:63:19)
          at Request.<anonymous> (/home/runner/work/VulnerableApp-facade/VulnerableApp-facade/facade-app/node_modules/jsdom/lib/jsdom/living/xhr/XMLHttpRequest-impl.js:655:18)
          at Request.emit (events.js:412:35)
          at ClientRequest.<anonymous> (/home/runner/work/VulnerableApp-facade/VulnerableApp-facade/facade-app/node_modules/jsdom/lib/jsdom/living/helpers/http-request.js:121:14)
          at ClientRequest.emit (events.js:400:28)
          at Socket.socketErrorListener (_http_client.js:475:9)
          at Socket.emit (events.js:400:28)
          at emitErrorNT (internal/streams/destroy.js:106:8)
          at emitErrorCloseNT (internal/streams/destroy.js:74:3)
          at processTicksAndRejections (internal/process/task_queues.js:82:21) undefined
      at VirtualConsole.<anonymous> (node_modules/jsdom/lib/jsdom/virtual-console.js:29:45)
      at Object.dispatchError (node_modules/jsdom/lib/jsdom/living/xhr/xhr-utils.js:66:53)
      at Request.<anonymous> (node_modules/jsdom/lib/jsdom/living/xhr/XMLHttpRequest-impl.js:655:18)
      at ClientRequest.<anonymous> (node_modules/jsdom/lib/jsdom/living/helpers/http-request.js:121:14)

though i have merged the newer code changes.

Justin Hong · Answer 12 · Thu Jul 21 2022 14:01:19 GMT+0800 (China Standard Time)

hm ok I've opened another PR: #76

Karan Preet Singh Sasan · Answer 13 · Thu Jul 21 2022 18:03:05 GMT+0800 (China Standard Time)

sure, let me check again.

Karan Preet Singh Sasan · Answer 14 · Thu Jul 21 2022 19:14:17 GMT+0800 (China Standard Time)

@Dripcoding I was checking the percentage of code coverage for VulnerableApp Facade, and it is 40%. Thanks a lot and amazing work.

Karan Preet Singh Sasan · Answer 15 · Thu Jul 21 2022 19:15:31 GMT+0800 (China Standard Time)

Karan Preet Singh Sasan commented 2 years ago

Justin Hong · Answer 16 · Fri Jul 22 2022 04:47:11 GMT+0800 (China Standard Time)

Your welcome :) I'm very happy to see the code coverage going up. We can definitely improve it if we do some refactoring and exclude files that don't need to be included in the reports.

I ran the Jest code coverage tool locally to obtain some more detailed results:

Karan Preet Singh Sasan · Answer 17 · Sun Jul 31 2022 12:21:48 GMT+0800 (China Standard Time)

Command to update the Jest snapshots: npm test -- --updateSnapshot