Add a github action to validate the PR.

Question

Add a github action to validate the PR.

preetkaran20 opened this issue 3 years ago · comments

Karan Preet Singh Sasan commented 3 years ago

There is currently no Github action that validates the PR. Add the action to validate both javascript/typescript changes (npm run build) and also Lua changes in the PR.

Karan Preet Singh Sasan · Answer 1 · Sun Sep 05 2021 19:21:23 GMT+0800 (China Standard Time)

Added the PR validation for the javascript/typescript module. Left part is LUA validation.

lawrence mcdonell · Answer 2 · Mon Jun 06 2022 14:26:14 GMT+0800 (China Standard Time)

I can help could you provide further requirement details? thanks

Karan Preet Singh Sasan · Answer 3 · Tue Jun 07 2022 00:54:59 GMT+0800 (China Standard Time)

Hi @lmcdo ,

So currently, this project has TypeScript/Javascript as well as Lua file (for openresty) and we are looking for a github action to compile and validate the PR before merging it into master.

Currently the github actions is there at https://github.com/SasanLabs/VulnerableApp-facade/blob/main/.github/workflows/Compile.yml and it is working fine for Typescript/Javascript but we want to include the LUA validator as well. Also I am not sure, if we are running unit tests for Typescript/Javascript as part of the PR build so wanted to validate that as well.

LUA script is present at: https://github.com/SasanLabs/VulnerableApp-facade/tree/main/lua-modules. it is invoked from https://github.com/SasanLabs/VulnerableApp-facade/blob/main/nginx.conf (nginx.conf)

Please let me know, if you need more information.

thanks,
Karan