Sandertv / mcwss

A websocket server for Minecraft Bedrock Edition

Home Page:https://godoc.org/github.com/Sandertv/mcwss

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Module path should be "github.com/Sandertv/mcwss", not "github.com/sandertv/mcwss"

KateGo520 opened this issue · comments

Background

Module path is inconsistent with go import path.
GO111MODULE=on, as README said, run go get github.com/Sandertv/mcwss:

go: downloading github.com/Sandertv/mcwss v1.2.0
go: github.com/Sandertv/mcwss upgrade => v1.2.0
go get: github.com/Sandertv/mcwss@v1.2.0: parsing go.mod:
        module declares its path as: github.com/sandertv/mcwss
                but was required as: github.com/Sandertv/mcwss 

Solution

Fix the module path:

  1. Rename the module path to "github.com/Sandertv/mcwss": https://github.com/Sandertv/mcwss/blob/master/go.mod#L1
module github.com/Sandertv/mcwss
require (
	…
) 
  1. Change the README document to use go get github.com/sandertv/mcwss.

@Sandertv @Tsubashi Could you help me review this issue? Thx :p

For backwards compatibility reasons I don't think renaming the module is an option. I'll change the README to use all lowercase.

Should be fixed in 0244b37, let me know if that is sufficient.

@Sandertv I think that's sufficient. Thank you for your reply.