Giters

Samsung / TizenFX

C# Device APIs for Tizen

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

NUI BindableObject IsSet, ClearValue

idkiller opened this issue · comments

commented

TizenFX/src/Tizen.NUI/src/public/XamlBinding/BindableObject.cs

Line 189 in 85e5457

internal bool IsSet(BindableProperty targetProperty)

TizenFX/src/Tizen.NUI/src/public/XamlBinding/BindableObject.cs

Line 158 in 85e5457

internal void ClearValue(BindableProperty property, bool fromStyle)

TizenFX/src/Tizen.NUI/src/public/XamlBinding/BindableObject.cs

Line 167 in 85e5457

internal void ClearValue(BindableProperty property)

TizenFX/src/Tizen.NUI/src/public/XamlBinding/BindableObject.cs

Line 176 in 85e5457

internal void ClearValue(BindablePropertyKey propertyKey)

Current NUI BindableObject has internal IsSet ClearValue methods.

  1. If the value is checked with GetValue without IsSet, You cannot check whether the property has been set or not.
    In addition, it creates an internal context and calls a callback to create a default value, which increases the meaningless load.

  2. Without ClearValue, Property cannot be returned to the default value. Because there is no way to call the default callback.

So ClearValue and IsSet must be public.
(It is also public in Xamarin.Forms.)

commented

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days