SWRT-dev / swrt-gpl

support bcm470x ipq40xx ipq807x mt7621 mt798x

Home Page:https://swrt.site/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

i don't think mt7621 supports CONFIG_WHNAT_SUPPORT

i3roly opened this issue · comments

yo @paldier,

i saw this commit

35deeba

i am not sure if MT7621 supports WHNAT because it requires "mediatek,wed" dts node.

if you look at openwrt's mtk_eth_soc.c driver in newer 5.x linux kernel, mediatek,wed node exists only for ARM-based devices (https://github.com/SUSE/kernel/blob/893e7de7ee89bdb6a4d59af80555a8704e23d65c/drivers/net/ethernet/mediatek/Kconfig)

are you sure WHNAT_SUPPORT works for MT7621?

i would like to see proper DTS configuratino for "mediatek,wed" nodes in MT7621.dtsi plus device dts.

right now this commit does not seem correct

edit: look in drivers/net/wireless/mediatek/mt7615e/mt_wifi/embedded/plug_in/whnat/wed.c:

it is looking for "mediatek,wed" node. i don't know how this would work...

MODULE_SUPPORTED_DEVICE("mt7615 within mt7622");
you are right

just wanted to check with you @paldier that's all.

not about "being right". just making sure we are working together since i rely on your updates to the MTK source.

i am happy your answer provides clarification.

will close ticket now.