Giters

SRombauts / UEGitPlugin

Unreal Engine 5 Git LFS 2 Source Control Plugin (beta)

Home Page:http://srombauts.github.io/UEGitPlugin

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

C4800: Implicit converion from int to bool

Elewyth opened this issue · comments

commented

Whenever I try to compile my C++ UE 4.25 project with VS2019 I get the following error(s):

`/Plugins/UE4GitPlugin/Source/GitSourceControl/Private/GitSourceControlProvider.cpp(130): error C4800: Implicit conversion from 'int' to bool. Possible information loss

/Plugins/UE4GitPlugin/Source/GitSourceControl/Private/GitSourceControlProvider.cpp(130): note: consider using explicit cast or comparison to 0 to avoid this warning

/Plugins/UE4GitPlugin/Source/GitSourceControl/Private/GitSourceControlProvider.cpp(287): error C4800: Implicit conversion from 'const int' to bool. Possible information loss

/Plugins/UE4GitPlugin/Source/GitSourceControl/Private/GitSourceControlProvider.cpp(287): note: consider using explicit cast or comparison to 0 to avoid this warning

/Plugins/UE4GitPlugin/Source/GitSourceControl/Private/GitSourceControlProvider.cpp(297): error C4800: Implicit conversion from 'const int' to bool. Possible information loss

/Plugins/UE4GitPlugin/Source/GitSourceControl/Private/GitSourceControlProvider.cpp(297): note: consider using explicit cast or comparison to 0 to avoid this warning`

I'm not sure why the build tool tires to compile the plugin in the first place, might be a configuration error on my side. Nonetheless it seems like there is a Warning in your code which is configured to be an error by default in either UE 4.25 or VS2019. I can fix it temporarily by disabling the error on my side, but a fix in the code would greatly be appreciated. I'll see if I can make a PR for this :).