RenderTexture Display Method Return Incorrect Type
Rosst0pher opened this issue · comments
sfRenderTexture_display return type disparity with CSFML.
sfRenderTexture_display currently returns bool
and supposed to return void
.
Was this fixed? I can't seem to find what you're mentioning.
CSFML
SFML.Net
SFML.Net/src/SFML.Graphics/RenderTexture.cs
Line 290 in 45b5a81
I'll close this for now, if you still see an issue, feel free to reopen it. 🙂
Hey @eXpl0it3r hope all is well
I just double checked what I raised here and can confirm this is still an issue if you check the pinvoke method which doesn't match CSFML return type.
https://github.com/SFML/SFML.Net/blob/master/src/SFML.Graphics/RenderTexture.cs#L554
https://github.com/SFML/CSFML/blob/master/include/SFML/Graphics/RenderTexture.h#L105
I haven't been active around SFML for some time now and unfortunately no longer have an environemnt setup to quickly fix this minor issue 😔I also don't see a reopen option, only to create a new one.
Ahh! I was looking at the function signature and not the pInvoke signature. Thanks for pointing me in the right direction.
I'll re-open it then. Feel free to provide a fix for it, otherwise someone else might pick it up, or I might eventually get to it 🙂