Build Fails After Last Commit on Master Branch

[benjschro]

Simply put, the HEAD of master (7627ef1) does not build. I was able to go back a single commit (cdc9bc6) and it builds just fine.

[Lukas Dürrenberger]

CI had no issue building CSFML, so what errors are you running into?

[benjschro]

I've tried on both Windows and a Linux VM - same error:

/root/CSFML/src/SFML/Graphics/Texture.cpp:186:1: error: expected unqualified-id before '{' token
  186 | {

If you look, there is a trailing semicolon after the function definition. If I remove it, it then gives the following error:

/root/CSFML/src/SFML/Graphics/Texture.cpp:189:59: error: no matching function for call to 'sf::Texture::update(sf::Texture* const&, unsigned int&, unsigned int&)'
  189 |     CSFML_CALL_PTR(destination, update(texture->This, x, y));

[Lukas Dürrenberger]

Ah there's a semicolon that shouldn't be there. Interesting that it builds fine in the CI, maybe it didn't grab the latest source. Guess that's what someone tried to communicate with #144 but given the lack of details, I didn't understand the issue. 🤔

Either way, there's already a PR for this: #143

[Lukas Dürrenberger]

Fixed with #143