Giters

SDFIdk / DHMQC

Processing suite for the Danish Digital Elevation Model

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Make use of proper configuration files (JSON) instead of variables in a python script

kbevers opened this issue · comments

commented

This proposal is two-fold:

  1. There is a lot of constants used in the QC-scripts, like tile_size, ground_classes, database connection-strings etc. It would be better to put them in a shared setup-file where the user can change them to their preference instead of changing it in the actual code.

  2. A script like dem_gen.py can take a lot of arguments (23 in fact) which is a bit of a pain to do from the command line. For this reason python "job-definitions" exists. They make life a lot easier, but also exposes the code to the user in a way that is less ideal. A general input-xml/yaml format for QC-scripts would solve this problem.