SAP / ui5-migration

ARCHIVED - A tool to support the migration of UI5 projects by adapting code for new UI5 framework versions.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

'migrate' sometimes adds a redundant dependency

codeworrior opened this issue · comments

While working on SAP/openui5@c782ce9 , I encountered the following issue with the ui5-migration tooling:

Sometimes, the cleanup of global names adds a dependency again although it exists already. This seems only to happen when the existing dependency uses a relative name (./library or ./Tokenizer).

Before:

sap.ui.define([
	...
	'./Tokenizer',
	...
],
function( ...

After:

sap.ui.define([
	...
	'./Tokenizer',
	...
	"sap/m/Tokenizer",
	...
],
function( ...

To reproduce, you can execute the following commands

cd openui5
git checkout 6555a38
ui5-migration migrate src/sap.m/src/sap/m/MultiComboBox.js