RyuzakiKK / NoteCrypt

Keep your notes safe and secure with Note Crypt for Android!

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Revoking permission at SelectDatabaseActivity crashes app

aper-project opened this issue · comments

commented

Hi, there, I've found a crash in version 1.44, which is downloaded from F-Droid.

I seems that it is related to the dangerous permission android.permission.READ_EXTERNAL_STORAGE and is triggered in the SelectDatabaseActivity. It can be caused when the app attempts to read external storage without either permission checking (via checkSelfPermission) nor permission request (via requestPermissions).

Reproduce crash

This crash can be reproduced on my Samsung device, following the steps:

  1. grant the storage permission for the app
  2. create a database in the main activity
  3. select a database and enter the SelectDatabaseActivity
  4. go to the system setting and revoke the storage permission
  5. back to the app and it crashes

@RyuzakiKK
Could you help me review this issue? If you need more information, I may make a video showing the crash. Very thanks!