RyanHirsch / partytime

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

SRT files use incorrect mimetype

jamescridland opened this issue · comments

Hi, Ryan,

Podnews Daily's RSS file offers transcripts in a variety of formats including an SRT file:

<podcast:transcript
 url="https://podnews.net/audio/podnews230113.mp3.srt"
 type="application/x-subrip"
 rel="captions"
/>

If I understand this line correctly, it is looking for: SRT = "application/srt"

The official specification uses the correct mimetype of application/x-subrip rather than this one. It was changed a while ago after someone correctly spotted the mimetype wasn't the proper one.

Podnews's transcripts appear not to show in various places, where they use your library.

A temporary workaround appear to be that I can add the incorrect mimetype of application/srt as well. I'll go and do that for now and see what happens.

However, I would suggest that the code quietly assigns SRT to both application/srt and application/x-subrip - but that the code is commented that "This is an incorrect but occasionally used alternative".

I've submitted an entirely untested kludgy fix here - #28 - but I'm not a JavaScript dev (at least, not a good one).