Unable to build any plugin

Question

Unable to build any plugin

Vermunds opened this issue 4 years ago · comments

The library itself compiles just fine.
However, any plugin that relies on it fails to compile with the same error messages. Example output here.
From what I can tell, it seems like the problem is caused by conflicts between the constants defined in SKSE/Impl/WinAPI.h and in Winnt.h.
Just including RE/Skyrim.h or SKSE/SKSE.h in my projects seems to include both implicitly (without including them these constants are not defined at all).
Any advice/fix would be appreciated.

Ryan McKenzie · Answer 1 · Fri Dec 18 2020 08:57:47 GMT+0800 (China Standard Time)

include windows.h (or xbyak) after commonlib

Vermunds · Answer 2 · Fri Dec 18 2020 09:19:35 GMT+0800 (China Standard Time)

Neither makes any difference. I don't even use xbyak in this case.

Ryan McKenzie · Answer 3 · Fri Dec 18 2020 09:20:39 GMT+0800 (China Standard Time)

show me your code

Vermunds · Answer 4 · Fri Dec 18 2020 09:29:00 GMT+0800 (China Standard Time)

It happens even with no code (aside from the load and query functions), but here is the one I'm trying, it's a rather simple one:
https://github.com/Vermunds/TimeFormatChanger-SE/tree/Test

Ryan McKenzie · Answer 5 · Fri Dec 18 2020 09:39:07 GMT+0800 (China Standard Time)

add SPDLOG_COMPILED_LIB to your defines

Vermunds · Answer 6 · Fri Dec 18 2020 09:49:53 GMT+0800 (China Standard Time)

Okay, that certainly helped. I'm now getting unresolved externals in WinAPI. At least it's something different. Anyways, here is it:

4>CommonLibSSE.lib(WinAPI.obj) : error LNK2019: unresolved external symbol GetFileVersionInfoSizeW referenced in function "unsigned int __cdecl SKSE::WinAPI::GetFileVersionInfoSize(wchar_t const *,unsigned int *)" (?GetFileVersionInfoSize@WinAPI@SKSE@@YAIPEB_WPEAI@Z)
4>CommonLibSSE.lib(WinAPI.obj) : error LNK2019: unresolved external symbol GetFileVersionInfoA referenced in function "bool __cdecl SKSE::WinAPI::GetFileVersionInfo(char const *,unsigned int,unsigned int,void *)" (?GetFileVersionInfo@WinAPI@SKSE@@YA_NPEBDIIPEAX@Z)
4>CommonLibSSE.lib(WinAPI.obj) : error LNK2019: unresolved external symbol GetFileVersionInfoW referenced in function "bool __cdecl SKSE::WinAPI::GetFileVersionInfo(wchar_t const *,unsigned int,unsigned int,void *)" (?GetFileVersionInfo@WinAPI@SKSE@@YA_NPEB_WIIPEAX@Z)
4>CommonLibSSE.lib(WinAPI.obj) : error LNK2019: unresolved external symbol VerQueryValueA referenced in function "bool __cdecl SKSE::WinAPI::VerQueryValue(void const *,char const *,void * *,unsigned int *)" (?VerQueryValue@WinAPI@SKSE@@YA_NPEBXPEBDPEAPEAXPEAI@Z)
4>CommonLibSSE.lib(WinAPI.obj) : error LNK2019: unresolved external symbol VerQueryValueW referenced in function "bool __cdecl SKSE::WinAPI::VerQueryValue(void const *,wchar_t const *,void * *,unsigned int *)" (?VerQueryValue@WinAPI@SKSE@@YA_NPEBXPEB_WPEAPEAXPEAI@Z)

Ryan McKenzie · Answer 7 · Fri Dec 18 2020 09:56:35 GMT+0800 (China Standard Time)

rebase on upstream

Vermunds · Answer 8 · Fri Dec 18 2020 10:02:24 GMT+0800 (China Standard Time)

I'm on the latest version already.

Ryan McKenzie · Answer 9 · Fri Dec 18 2020 10:10:39 GMT+0800 (China Standard Time)

link version.lib

Vermunds · Answer 10 · Fri Dec 18 2020 10:20:41 GMT+0800 (China Standard Time)

And that did it. It compiles now. A lot of warnings though, but I'm not complaining. It works.
Thanks for the help.

Ryan McKenzie · Answer 11 · Fri Dec 18 2020 10:22:42 GMT+0800 (China Standard Time)

This process is a lot easier if you use the cmake integration

Vermunds · Answer 12 · Fri Dec 18 2020 10:27:06 GMT+0800 (China Standard Time)

Yeah I figured. I'm just not too used to CMake yet.