RxSwiftCommunity / RxViewModel

ReactiveViewModel-esque using RxSwift

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Unable to use when inherited

calvingit opened this issue · comments

Install from Cocoapods, the Xcode shows below error message:

'disposeBag' is inaccessible due to 'internal' protection level

Hey @calvingit thanks for reporting.

Would you mind telling me which version of Xcode and also which version of RxViewModel are you trying to use?

Thanks

Xcode: 8.3.3
RxViewModel: 5.0.0

Thanks; I'll take a look later today and hopefully I'll be able to release a new version addressing this issue.

Thanks for reporting.

@calvingit Could you change

RxViewModel.swift:L25 to
public private(set) var disposeBag = DisposeBag()

And confirm if that helps your issue ?

No problem if the disposeBag is public

This project isn't super active - feel free to make a PR with the code I suggested above:

public private(set) var disposeBag = DisposeBag()

Guys, disposeBag is still not public, every-time i update pods i have to edit it to be public and I think this class is supposed to be superclass. Would you mind changing please? I can make PR buts its so tiny change that its a waste of time :)
Thanks for your time

Check PR #63

Fixed with #63 and adb7865