RxSwiftCommunity / RxViewModel

ReactiveViewModel-esque using RxSwift

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

You should make RxViewModel class "open"

lovesuper opened this issue · comments

commented

I have Cannot inherit from non-open class 'RxViewModel' outside of its defining module all around my project because of you annotate rxviewmodel class with "public" annotation instead of "open"

You are 💯 correct @lovesuper.

I just replaced the one public usage for open to make the class subclassable.

Once CI is 💚 I'll merge and release a new version.

This should be fixed now; i'll release a new version in the next hour

🚫 done