RudeySH / lastfm-bulk-edit

Bulk edit your scrobbles for any artist, album or track on Last.fm at once.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Enable browser dropdown list for previously entered terms

hans-juergen opened this issue · comments

The bulk edit script seems to disable the usual browser-based dropdown list if you enter a name that you already have edited before. This works for the usual bulk editing of tracks without the script, but not with it. This dropdown list of previously entered terms can be handy when doing similar edits like changing the album artist to "Various Artists" for example, as you only have to type the first character to make it appear then.

The script disables the browser's history-based autocomplete feature because it provides it's own datalist of items to use for autocomplete. Let me explain what I mean.

image

When bulk-editing an artist, the track and album fields are often "Mixed". In the image above, the scrobbles that are being edited are scrobbled on 12 different albums. The script disables the browser's autocomplete and instead provides a dropdown list based on those 12 albums, see the image below.

image

While it's possible to combine this list with the browser's history-based dropdown list, I'd rather not do that. Doing so may be confusing, users wouldn't be able to tell what items from such combined list are part of the history, or part of the 12 albums (in the example above). However...

image

As the image above might suggest, the script also replaces the browser's history-based autocomplete for fields that only have one known value.

At the very least, the script can be changed to keep the browser's history on for fields that are not "Mixed". Would this change be sufficient for your use case, @hans-juergen?

Right, probably that would be enough if the dropdown worked for only one autocomplete item. I often have the case that I have to manually type "Various Artists" as the album artist and wished I could only type a single "v" to click on it with the mouse.

Also related to the autocomplete feature of modern browsers: track titles in classical music can be very long (too long for the shown part of the input field), so you cannot see the end on the right side where the important details are to differentiate between a correct and a wrong saved item. Maybe it is possible to offer a small popup then showing the complete track title?

MS Edge also offers deleting misspelled autocomplete items with a trashcan icon in the dropdown list which is not available with your script, as far as I remember.

Alright, v0.3.4 is out now and it restores the browser's autocomplete for fields that are not in the "Mixed" state.

As for your other suggestions, unfortunately these dropdown menus can't be customized because those are provided by the browser themselves, not the website or script. I can't add popups or trashcan icons to these dropdowns.

And thanks again, great! I just tested it while bulk editing some album artists to "Various Artists", and Edge still shows the trashcan on the right:

Bulk Editor Autocomplete dropdown in Edge

I also updated the related support forum thread:
https://support.last.fm/t/bulk-scrobble-edit-script-updated/42185/5

It seems that using the browser's autocomplete feature does not work anymore. As your script has not been updated, I guess there was a change somewhere else? I am currently using MS Edge, but will check in Opera as well.

OK, works as it should in Opera 77.0.4054.172, so it seems to be an issue with the latest Edge versions, currently 91.0.864.64. My Windows 10 Home is version 21H1 with latest updates, build 19043.1081.