Pumpkaboo family allignment
MelkyAir opened this issue · comments
Currently the two pumpkaboo families have tags different from the ingame sizes.
They go from XS, none, XL, XXL in the tool, but ingame they are Small Size, Average Size, Large Size, Super Size.
The usage of XL and XXL is confusing, as Large Size would be just an L, where we now use XL, which is Extra Large aka Super Size.
Could we change these to match the ingame sizes?
e.g. Sm, Av, La, Su
e.g Sm, As, Ls, Ss
e.g. S, M, L, XL
Second, the difference between the costume and the regular is also very difficult to see.
Could we add a top hat emoji to the tag too?
e.g. Sm🎩, Av🎩, La🎩, Su🎩
Last, the tags for pumpkaboo fall outside the borders. Could they be displayed with a "< cr >" or similar so the tag would be under the name?
for names, please refer to #166
The names were changed to reflect the size TAGS used in the game. I don't think there was room to implement both the size name and the size tag. I'm not sure how to put things on two lines.
I certainly don't agree to simply rename them and ignore the size tag. I custom name them all so that the only real way to tell them apart definitively is the size tag assigned in the game.
I wasn't aware of this CR.
I don't want both size name and size tag. I suggested to change the tag to match the ingame name.
The confusing part is just why Small Size has tag XS (Xtra Small), Large size has tag XL (Xtra Large), and Super Size has tag XXL (Xtra Xtra Large).Why not stick to the closest size for the tag, S for small, L for Large and XL for Super Size?
Benefit would also be that the tags will be shorter, so they fit in the borders of the image.
The situation before CR#166 seems to me better matching the ingame names than after the change.
What in game names are you referring to? The initial name the game uses is not immutable--you can change it. I change the names all the time:
The only thing that is immutable are the size tags:
I'm referring to the names in the pokedex
I'm not in agreement to use those names. They are not searchable or identifiable in any way. Only the size tag is searchable and identifiable when viewing the details of a mon.
OK, fair enough. Could you then only add the hat emoji to the costumed ones?
I think that the identifier char(name_suffix) is not based on their (local) name.
For example: Charizard(M-X), we just use M for MEGA in simple way.
So, that just helps to identify them.
And then, the next question is:
Could XS, XL, XXL be good to identify different size for Pumpkaboo family.
I think @BartmanEH 's second comment is good:
The size tag is immutable.
For now, the name_suffix property is used for different language.
So I think that is not good to use Sm, Av, La, Su for name suffix, the user in different language will be confused.
And XS, XL, XXL are used in all language, because they are just label.
And last, I don't know it is okay or not to add a hat emoji to them.
They just are different costume style.
Or, should we add hat as suffix for all Pikachu with hat?
I think you made a strong case why this is chosen over my suggestion. I will have to live with it.
Would you, @Rplus, be able to comment if we can have a cariage return in the name? For example Pumpkaboo (XXL) is a fraction to wide for the image block. So the last part of (XXL) falls outside the borders. If we would be able to move the tag below the name this would solve that.
In regard to the emoji to the costumed pumpkaboo. We only add emoji's if the image is to difficult to identify the difference.
e.g with the genesect family, or in this case the pumpkaboo and gourgeist with or without a hat. The difference in the image is almost not visible.
Agree it could be nice with something on the pumpkaboo to indicate that its a costume.
Pikachu dont need it.
But other costume pokemon ,there the difference between ordinary and costume is hard to see.. : butterfree,delibird,blitze,elekid family
The first one in the list is the normal one and the one after is the costume one. Seems pretty simple to me.
@Rplus I tried injecting style "font-stretch" into the div but it had no effect:
Is there a way I can affect the font of a specific mon?
@Rplus I tried injecting style "font-stretch" into the div but it had no effect:
Is there a way I can affect the font of a specific mon?
font-stretch just support some* font-family, not always works.
style="transform: scaleX(0.85); transform-origin: 0 0;" works well. How do I add that to just the text part?
EDIT: I manually added a space before the suffix tag and that seems to break the name over two line so I've made a PR #351 to try this out. It conflicts with the hover tag that appears but maybe that's acceptable.
The alligment now looks great @BartmanEH. Did you want to add the emoji too, or was it voted against it? If so, I'll close this issue.
Wanted to do one at a time so it's easy to undo. I'll do a PR to add top hat shortly.
PR #353 closes this issue.
Under great duress :-) we added a top hat emoji to costume Pumpkaboo family. We iterate that costume pokemon always follow the non-costume version in the list. It should be easy to distinguish them by order in the list. At this time, the author is not prepared to retro-actively name costume pokemon across the board so consider this a one-time exception. Thanks and please close this issue.