Giters

Rostlab / nala

Text mining of natural language mutations mentions

Home Page:https://www.tagtog.net/-corpora/IDP4+

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Declare dependency pycrfsuite

juanmirocks opened this issue · comments

commented 
ImportError: No module named 'pycrfsuite'
pip install pycrfsuite
Collecting pycrfsuite
  Could not find a version that satisfies the requirement pycrfsuite (from versions: )
No matching distribution found for pycrfsuite

Are you guys using this module?

https://github.com/tpeng/python-crfsuite

commented

I already talked about this on Skype :)
pip install python-crfsuite

commented

Good, sorry if I missed it. Can't we have the dependency declared in the install file ?

commented

Sure we can add it. The problem is that on windows installing it is not always straightforward.

commented

? So what's the solution? I better declare this dep somehow, at least within the README installation instructions

commented

The problem as I see it is:

  1. if we include it in setup.py ... The Windows user will try to pip install nala and might fail because pycrfsuite might fail, then we assume 'they will notice it's not nala but a dependecy and try to install it separately'. The Unix user should be fine
  2. If we don't include it in setup.py... We have to add it in readme, with an additional short tutorial on how to install python-crfsuite on Windows before installing nalaf/nala
  3. We do include it in setup.py as 1) But put the info for Windows users that it might fail and what to try in some FAQ

I like 3) best