Node 5.x compatibility broken

Question

Node 5.x compatibility broken

JanKoudijs opened this issue 7 years ago · comments

The latest commit breaks the Node 5.x compatibility. It is the addition of a parameter default at line 74 of moo.js.

Was this overseen or is it the idea to increase the minimum Node version to 6.x?

I stumbled on this while performing tests on a Windows XP VM (using XP Embedded updates :) ). The latest Node version that runs on XP is 5.12.0.

Ben Coburn · Answer 1 · Thu Jul 27 2017 00:02:31 GMT+0800 (China Standard Time)

I will fix this, we didn't intend to break Node 5.x compatibility.

Ben Coburn · Answer 2 · Thu Jul 27 2017 00:38:58 GMT+0800 (China Standard Time)

I believe this to be fixed in commit 2578a44, I have tested at the level of confirming that ping works on node 5.12.0 using https://github.com/creationix/nvm under Ubuntu Linux

Jan Koudijs · Answer 3 · Thu Jul 27 2017 02:15:43 GMT+0800 (China Standard Time)

Yep, it's fixed.
Within an hour, you guys are impressive!

Thanks (also for the link to the test tool).