Save app user id instead of using its username
marceloschmidt opened this issue · comments
When the app creates a user, it should store its userId in its settings and refrain from using the bot's username app.appname. A bot's username is editable. A userId is not.
Hi @marceloschmidt ! Not sure I followed but what does store its userId in its settings mean? Do you mean we cann't provide
If so, yeah I agree. Perhaps, we need to move it under read to get its value dynamically. What do you think of it? @d-gubert
Yes exactly. You're forcing the app to use a username that is mutable. My opinion is that we should allow the apps to change that...
did you mean that UserID will never change after creation while the username is not, so we need to depend on the UserID in the code instead of the username ?
Yes, exactly.
I will try to solve it.
Hi @AymanAzzam . Are you working on it? If you are working it then I can move the focus to other issues to make sure we don't do the duplicate work.
Hi @lolimay . I'm facing some problems in opening the project as I told you on Rocket.Chat. so when I solve them, I will work on this issue.
Hi @lolimay . I'm facing some problems in opening the project as I told you on Rocket.Chat. so when I solve them, I will work on this issue.
Great! What's your username on open.rocket.chat server?
Hi @lolimay . I'm facing some problems in opening the project as I told you on Rocket.Chat. so when I solve them, I will work on this issue.
Great! What's your username on open.rocket.chat server?
ayman.azzam16
@lolimay any update here?
@lolimay any update here?
Hi, @marceloschmidt . I have made a pr #257 by deprecate getAppUserUsername method and introduce read.getAppUser method. @d-gubert should inlcude these commits on beta version later (#260).
Closing as it has been solved on v1.14