Why is method getQRText private?

Question

Why is method getQRText private?

JonathanTru opened this issue 8 years ago · comments

awesome library, but I don't want to use any of the QRCode Providers, rather I pass the QRCodeText to the Client and have the Javascript Library qrcode.js render the QRCode.

Could you explain to me why the method getQRText() is private? Are you open to changing that to public?

Rob Janssen commented 8 years ago

#7

Rob Janssen · Answer 1 · Wed Jun 22 2016 17:13:41 GMT+0800 (China Standard Time)

Could you explain to me why the method getQRText() is private?

I always start out private and make stuff protected or public as needed; (up until now) it wasn't required to make the method public hence the private access modifier.

Are you open to changing that to public?

I am. I don't directly see a problem in that. I'll change it and create a new release tonight / soon(-ish).