Replace Prophecy mocks with PHPUnit mocks

Question

Replace Prophecy mocks with PHPUnit mocks

asgrim opened this issue 5 years ago · comments

James Titcumb commented 5 years ago

As it says on the tin.

Yılmaz · Answer 1 · Sat Feb 08 2020 05:50:40 GMT+0800 (China Standard Time)

I would like to propose a PR for this today.

Ben Scholzen · Answer 2 · Sat Feb 08 2020 06:28:15 GMT+0800 (China Standard Time)

Usually Prophecy was much more elegant that PHPUnit's internal mocks. Did that change?

Marco Pivetta · Answer 3 · Sat Feb 08 2020 06:33:54 GMT+0800 (China Standard Time)

Too magic, and un-typed. Phpunit mocks are generally simpler and work much better for anything related to static analysis.

…

On Fri, Feb 7, 2020, 23:28 Ben Scholzen ***@***.***> wrote: Usually Prophecy was much more elegant that PHPUnit's internal mocks. Did that change? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#8?email_source=notifications&email_token=AABFVECUJ6KAYNEKJ6NSAVTRBXOABA5CNFSM4KRMYMIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELE3GEA#issuecomment-583643920>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABFVEAZIPMI7RIBJM6JHW3RBXOABANCNFSM4KRMYMIA> .

James Titcumb · Answer 4 · Sun Feb 09 2020 17:50:04 GMT+0800 (China Standard Time)

Fixed by #12