Replace Prophecy mocks with PHPUnit mocks
asgrim opened this issue · comments
As it says on the tin.
I would like to propose a PR for this today.
Usually Prophecy was much more elegant that PHPUnit's internal mocks. Did that change?
Too magic, and un-typed. Phpunit mocks are generally simpler and work much
better for anything related to static analysis.
…On Fri, Feb 7, 2020, 23:28 Ben Scholzen ***@***.***> wrote:
Usually Prophecy was much more elegant that PHPUnit's internal mocks. Did
that change?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8?email_source=notifications&email_token=AABFVECUJ6KAYNEKJ6NSAVTRBXOABA5CNFSM4KRMYMIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELE3GEA#issuecomment-583643920>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFVEAZIPMI7RIBJM6JHW3RBXOABANCNFSM4KRMYMIA>
.
Fixed by #12