Dependency range is broken
Ocramius opened this issue · comments
psr-container-doctrine/composer.json
Line 19 in 653bdba
This is an exercise in "eating our own dogfood" - this is probably from the initial fork of the project, when it was first imported in roave/, but we should really use a stricter range here.
Gah, I let this slip through in #35 sorry >.<
Happens 🤷
Still, we should fix this.
Author of #35 here. Even if I do more Java than PHP nowadays, I would gladly help if you can assist me on things needs to be considered or the range we need to focus.
@edigu take it easy, it's nothing too critical.
In practice, that range needs to become:
->=7.4
+^7.4 || ~8.0.0 || ~8.1.0That effectively translates to:
- Anything between 7.4 and 8.0 (excluded)
- anything between 8.0.0 and 8.1.0 (excluded)
- anything between 8.1.0 and 8.2.0 (excluded)
This is because PHP is not SemVer compliant, and breaks at every minor.
Everything looks okay in PHP 7.4, waiting CI for other builds.
Update: Omg. 8 and 8.1 already failed due to a mandatory composer update. Was there a specific reason to commit composer.lock file in this project? Isn't it needs to be re-generated as the platform version changes?