Add Unit Tests

Question

Add Unit Tests

Rishit-dagli opened this issue 3 years ago · comments

The tests should check for the rank and shape of the output tensors, the test should override tf.test.TestCase base class.

Feel free to take inspiration from:

https://github.com/Rishit-dagli/Fast-Transformer/blob/main/fast_transformer/test_fast_transformer.py
For parametrization feel free to follow https://stackoverflow.com/a/34094/11878567, can be used in the exact same way with subTest in TensorFlow

Kaushik Tummalapalli · Answer 1 · Mon Jan 17 2022 18:06:51 GMT+0800 (China Standard Time)

Hey, I'll give it a try! Thanks

Rishit Dagli · Answer 2 · Mon Jan 17 2022 18:24:41 GMT+0800 (China Standard Time)

I have assigned this issue to you, feel free to go over 2 of the reference links if you are new to unit testing or tf.test in particular. Apart from the PR reviews feel free to ask if you have any more questions. Also, I'll leave it up to you if you want to address each of the checkboxes in their own PRs or combine them in a single PR.

Rishit Dagli · Answer 3 · Wed Feb 02 2022 21:58:59 GMT+0800 (China Standard Time)

Hey, @kaushik-42 I will take this up for now after the DM you sent me.