Giters

RikkiGibson / Corvallis-Bus-Android

The Android client for the Corvallis Bus service.

Home Page:https://rikkigibson.github.io/corvallisbus

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix race in StopsFragment.java

RikkiGibson opened this issue · comments

commented

The null check on selectedStopId should probably be followed by assignment to a local final int which is then referenced in the doInBackground callback.

https://github.com/RikkiGibson/Corvallis-Bus-Android/blob/master/mobile/src/main/java/osu/appclub/corvallisbus/browsestops/StopsFragment.java#L210

commented

Fixed as a side effect of moving to static AsyncTask subclasses.