Giters

Rightpoint / RZTransitions

A library of custom iOS View Controller Animations and Interactions.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Library only works when window.rootViewController is RZTransitionNavigationController

fladdict opened this issue · comments

commented

If window.root is jus UIViewController, dismiss transition doesn't really works when pushing modal view.

commented

I can attest to this as well (regardless of the window.rootViewController).

It seems that the defaultPresentDismissAnimationController is overwriting the specific transitions that are set for the view controller that is presented modally.

So if the default defaultPresentDismissAnimationController is not set, i.e. nil, then it uses the default transition UIKit transition.

As workaround you can do:

id<RZAnimationControllerProtocol> animationController = ...

[[RZTransitionsManager shared] setDefaultPresentDismissAnimationController:animationController];
[self presentViewController:nc animated:YES completion:^{
    [[RZTransitionsManager shared] setDefaultPresentDismissAnimationController:nil];
}];

Same on dismiss:

id<RZAnimationControllerProtocol> animationController = ...

[[RZTransitionsManager shared] setDefaultPresentDismissAnimationController:animationController];
[self dismissViewControllerAnimated:YES completion:^{
    [[RZTransitionsManager shared] setDefaultPresentDismissAnimationController:nil];
}];

This issue is only apparent with RZTransitionAction_PresentDismiss, works as expected with RZTransitionAction_PushPop.

@Arrouse Has this been addressed in the 1.2.0 release?

commented

Is it related to the issues raised in this SO question/answer?
http://stackoverflow.com/a/25193675/592739