`.replace` replacing removed code

Question

fisker opened this issue 2 years ago · comments

> new (require('magic-string'))('00').remove(0, 1).replace('0', '1').toString()
'10'

Shouldn't the result be 1?

Anthony Fu · Answer 1 · Thu Sep 22 2022 21:33:28 GMT+0800 (China Standard Time)

.replace matches against the original string, which is a document caveat. I am not sure if there is a way to improve that, if so I am open for PR.

fisker Cheung · Answer 2 · Thu Sep 22 2022 21:48:19 GMT+0800 (China Standard Time)

I'm not sure exactly how it works, I generated a new MagicString before replacing for now. prettier/prettier@77ac062

Tal500 · Answer 3 · Tue Oct 04 2022 15:30:56 GMT+0800 (China Standard Time)

.replace matches against the original string, which is a document caveat. I am not sure if there is a way to improve that, if so I am open for PR.

Is it problematic to get as parameter if the user wants to perform the search on the original string or not?