ACPI configuration parsing issue

Question

ACPI configuration parsing issue

vbourachot opened this issue 8 years ago · comments

Trying to configure via ACPI, there seems to be an issue with custom commands parsing. The contents of the first custom command in the ssdt is repeated for all custom command entries in the configuration.

Debug log excerpt below - the corresponding ssdt has 4 different custom commands with the first one being 0x01970725:

CodecCommander: Version 2.5.0 starting on OS X Darwin 15.3.
[...]
CodecCommander: Custom Command
CodecCommander: ...Command: 0x01970725
CodecCommander: ...OnInit: true
CodecCommander: ...OnWake: true
CodecCommander: ...OnSleep: false
CodecCommander: Custom Command
CodecCommander: ...Command: 0x01970725
CodecCommander: ...OnInit: true
CodecCommander: ...OnWake: true
CodecCommander: ...OnSleep: false
CodecCommander: Custom Command
CodecCommander: ...Command: 0x01970725
CodecCommander: ...OnInit: true
CodecCommander: ...OnWake: true
CodecCommander: ...OnSleep: false
CodecCommander: Custom Command
CodecCommander: ...Command: 0x01970725
CodecCommander: ...OnInit: true
CodecCommander: ...OnWake: true
CodecCommander: ...OnSleep: false
CodecCommander: Getting EAPD supported node list.

Debug log: https://github.com/vbourachot/XPS13-9350-OSX/blob/master/misc/codec_commander-1.log
SSDT source: https://github.com/vbourachot/XPS13-9350-OSX/blob/fcb674b0244f6e85ceb5498250041e07dac2aafd/ssdt/SSDT-ALC256.dsl

RehabMan · Answer 1 · Sun Feb 07 2016 06:58:15 GMT+0800 (China Standard Time)

Install debug CodecCommander.kext. Post ioreg using IORegistryExplorer v2.1. Also post EFI/Clover folder (remove 'themes'). Compress all as ZIP.

RehabMan · Answer 2 · Sun Feb 07 2016 09:23:34 GMT+0800 (China Standard Time)

I think I see the problem (and fixed). Try latest build.

vbourachot · Answer 3 · Mon Feb 08 2016 00:08:39 GMT+0800 (China Standard Time)

Confirmed working - thanks for the fix.

CodecCommander: Version 2.5.1 starting on OS X Darwin 15.3.
[...]
CodecCommander: Custom Command
CodecCommander: ...Command: 0x01970725
CodecCommander: ...OnInit: true
CodecCommander: ...OnWake: true
CodecCommander: ...OnSleep: false
CodecCommander: Custom Command
CodecCommander: ...Command: 0x02170883
CodecCommander: ...OnInit: true
CodecCommander: ...OnWake: true
CodecCommander: ...OnSleep: false
CodecCommander: Custom Command
CodecCommander: ...Command: 0x02050036
CodecCommander: ...OnInit: true
CodecCommander: ...OnWake: true
CodecCommander: ...OnSleep: false
CodecCommander: Custom Command
CodecCommander: ...Command: 0x02041737
CodecCommander: ...OnInit: true
CodecCommander: ...OnWake: true
CodecCommander: ...OnSleep: false